Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add OnlyFans #865

Merged
merged 4 commits into from
Oct 28, 2024
Merged

feat: add OnlyFans #865

merged 4 commits into from
Oct 28, 2024

Conversation

SirMonteiro
Copy link
Contributor

Thank you for your contribution! Before sending this Pull Request, please confirm the following:

  • You have read the contributing guidelines
  • The icon's size is under 1,024 Bytes
  • The layout of the SVG looks like this including newlines
<svg xmlns="http://www.w3.org/2000/svg"
aria-label="..." role="img"
viewBox="0 0 512 512"><path
d="m0 0H512V512H0"
fill="#fff"/> ... </svg>

If you have done the above, please send the Pull Request.
Closes #853

@edent
Copy link
Owner

edent commented Oct 24, 2024

This looks a bit off-centre to me. Or am I wrong?

@SirMonteiro
Copy link
Contributor Author

I tried to fit the entire icon into green and yellow zones from guidelines, but centering it looks better.

@Eiim
Copy link
Collaborator

Eiim commented Oct 25, 2024

It's effectively centered (technically a half-pixel off), but arguably looks uncentered because the visual weight of the logo is skewed to the left. It's subjective but I think it looks fine as it is.

@edent
Copy link
Owner

edent commented Oct 25, 2024

Looks good! Could you please make sure it fits the formatting template, then I'll merge it. Thanks :-)

@SirMonteiro
Copy link
Contributor Author

The border hits the yellow mark, but it fits all requirements!

@edent
Copy link
Owner

edent commented Oct 25, 2024

@SirMonteiro sorry - I meant the line-breaks within the SVG file.

@edent edent merged commit f8d6429 into edent:master Oct 28, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add OnlyFans icon
3 participants
@SirMonteiro @edent @Eiim